Skip to content

Add a JSON addition for Enumerator::ArithmeticSequence #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
havenwood wants to merge 1 commit into from
Closed

Add a JSON addition for Enumerator::ArithmeticSequence #583

havenwood wants to merge 1 commit into from

Conversation

@havenwood
Copy link

@havenwood havenwood commented May 4, 2024

This PR adds a JSON addition for Enumerator::ArithmeticSequence since it was added to the Ruby stdlib.

##
# Existing Range support
require 'json/add/range'
(0..42).to_json

##
# Proposed Enumerator::ArithmeticSequence addition
require 'json/add/arithmetic_sequence'
((0..42) % 3).to_json

I forgot JSON was a gem yesterday and made a PR to Ruby and filed feature request. I realized my mistake this morning, and opened this PR. 🙂

nobu
nobu reviewed May 7, 2024
View reviewed changes
@havenwood havenwood force-pushed the add_json_arithmetic_sequence branch from 3967bb0 to 04e299a Compare May 7, 2024 18:05
@byroot
Copy link
Member

byroot commented Oct 17, 2024

Thanks for the PR but I don't wish to add any more json/add classes.

@byroot byroot closed this Oct 17, 2024
@hsbt
Copy link
Member

hsbt commented Oct 18, 2024

FYI: https://bugs.ruby-lang.org/issues/19528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nobu nobu nobu left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@havenwood @byroot @hsbt @nobu